Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-551) adding unset to config commands #545

Closed
wants to merge 1 commit into from
Closed

(GH-551) adding unset to config commands #545

wants to merge 1 commit into from

Conversation

zhao-xu
Copy link
Contributor

@zhao-xu zhao-xu commented Jan 15, 2016

Add unset to config commands so proxy can be switched on/off in scripts.

For example:

choco config set proxy http://localhost:8118
choco install package_requires_proxy_to_install
choco config unset proxy
choco install package_do_not_need_proxy_can_speed_up

Closes #551

@ferventcoder
Copy link
Member

This is great as far as the code goes! I thought I had already created an issue for this - but apparently I never got to actually creating the issue. Would you read over https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md and create the issue and then update your commit message as mentioned in the document? Then we can move forward with this!

@zhao-xu
(chocolateyGH-551) Add unset to Config Commands
044d3d5 
Proxy can be set by 'config set proxy server', but there is no way to
turn that off. A new command 'config unset proxy' is created to do the
job.
@zhao-xu
Copy link
Contributor Author

zhao-xu commented Jan 16, 2016

Sorry, I forgot that. Document's too long, didn't read them all :-p
I went throught the issue list last night and didn't find any related so I created a new one #551
Commit message has been updated to metion the issue number.

I'm not sure whether I should create a new PR or this one will be updated automaticlly?

@ferventcoder
Copy link
Member

Document's too long, didn't read them all :-p

Better to document explicit expectations rather than leave it up for folks to interpret themselves. :)

@ferventcoder ferventcoder changed the title adding unset to config commands (GH-551) adding unset to config commands Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhao-xu @ferventcoder